Skip to content

Fix cast type error #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vvchens wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix cast type error #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb24aad
Fix cast type error
vvchens Feb 9, 2023
8877b7d
Remove .Net4.5 4.6 4.7
vvchens Feb 9, 2023
8e8570e
Update README.md
vvchens Feb 9, 2023
520ccc6
Update Percy.cs
vvchens Feb 9, 2023
08f2f7d
correct typo
vvchens Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Forked from [Origin](https://github.com/BrowserStackCE/percy-csharp-selenium), fixed a cast type error and remove .Net 4.5 4.6 4.7

# Percy C# Selenium

[Percy](https://percy.io) visual testing for C#.NET Selenium. (Supports both .NET Core and .NET Framework - 4.5 to 4.8)
[Percy](https://percy.io) visual testing for C#.NET Selenium. (Supports both .NET Core and .NET Framework - 4.8)

## Requirements

Expand Down
4 changes: 2 additions & 2 deletions percy-csharp-selenium/Percy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ private String BuildSnapshotJS(String enableJavaScript)
{
StringBuilder jsBuilder = new StringBuilder();
// the double {{ and }} are needed to escape the curly braces
jsBuilder.Append(String.Format("return PercyDOM.serialize({{ enableJavaScript: {0} }})\n", enableJavaScript.ToLower()));
jsBuilder.Append(String.Format("return PercyDOM.serialize({{ enableJavaScript: {0}, stringify_response: true }})\n", enableJavaScript.ToLower()));
return jsBuilder.ToString();
}

Expand All @@ -282,4 +282,4 @@ private void Log(String message)
}

}
}
}
2 changes: 1 addition & 1 deletion percy-csharp-selenium/percy-csharp-selenium.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>netcoreapp3.1;net45;net46;net47;net48</TargetFrameworks>
<TargetFrameworks>netcoreapp3.1;net48</TargetFrameworks>
<RootNamespace>percy_csharp_selenium</RootNamespace>
<PackageVersion>1.0.1-alpha</PackageVersion>
<ReleaseVersion>1.0.1-alpha</ReleaseVersion>
Expand Down