Skip to content

Improved UI and fixed state bug #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VishalChouhan17 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved UI and fixed state bug #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class App extends React.Component {
loading: false,
repositories: [],
labels: ["good first issue", "help wanted"],
loadingMessage: "Fetching Issues... ",
loadingMessage: "loadingMessage: Searching GitHub for beginner-friendly repos... ",
minGoodFirstIssues: 1,
minStars: 0,
minDate: initMinDate(),
Expand Down Expand Up @@ -99,7 +99,7 @@ class App extends React.Component {
} else {
expandedTableRows.add(i);
}
this.setState(expandedTableRows);
this.setState({expandedTableRows});
};

const setMinDate = e => this.setState({ minDate: e.target.value });
Expand All @@ -117,7 +117,8 @@ class App extends React.Component {
<div
style={{
margin: "0 auto",
maxWidth: 900
maxWidth: 1200,
padding: "20px"
}}
>
{Header()}
Expand Down
2 changes: 1 addition & 1 deletion src/formSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export function MinGoodFirstIssues(props) {
}

export function MinStars(props) {
const options = [0, 1, 2, 3, 4, 5, 10, 25, 50, 100, 250, 500, 1000].map(
const options = [ 50, 100, 250, 500, 1000].map(
mapOptions
);
return (
Expand Down