Skip to content

Conversation

@merrielle
Copy link
Collaborator

@merrielle merrielle commented Feb 21, 2023

Pull Request doc

CURRENT STATUS:

  • all maps working for both europe and usa
  • tooltips on interconnection map: broken for europe, working for usa. Most likely won't fix as this is due to shapefile data.
  • utilization map: blank for europe, working for usa (Cause is unclear because bind and risk maps work for europe!)
  • emissions maps: need to remove hardcoded carbon resource types such as ng and coal
  • fixing ModelImmutables, which should be fetched from the grid object instead of CSV files
    • this should fix a handful of the non-map graphs, which break while trying to load those CSVs
  • tests have been omitted until they're in better shape

Purpose

What is the larger goal of this change?

What the code is doing

How is the purpose executed?

Testing

How did you test this change (unit/functional testing, manual testing, etc.)?

Where to look

  • It's helpful to clarify where your new code lives if you moved files around or there could be confusion/

  • What files are most important?

Usage Example/Visuals

How the code can be used and/or images of any graphs, tables or other visuals (not always applicable).

Time estimate

How long will it take for reviewers and observers to understand this code change?

@merrielle merrielle changed the title [DRAFT] feat: add support for europe_tub grid model in plotting functions feat: add support for europe_tub grid model in plotting functions Feb 27, 2023
@merrielle merrielle force-pushed the merrielle/add_europe_to_maps branch from 89c3d69 to 6309d73 Compare February 27, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants