rework buffs scanning #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Alessandro-Barbieri
force-pushed
the
buffs_scanning
branch
2 times, most recently
from
d3d6ffc to
8c849c1
Compare
Alessandro-Barbieri
force-pushed
the
buffs_scanning
branch
from
8c849c1 to
1b46707
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Owner
In both cases I'd say the first alternative. Kind of depends on the conditionals though. |
* check for more parry abilities * split enemy miss chance, dodge, parry, dodge and block calculation
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [leafo/gh-actions-lua](https://github.com/leafo/gh-actions-lua) from 10 to 11. - [Release notes](https://github.com/leafo/gh-actions-lua/releases) - [Commits](leafo/gh-actions-lua@v10...v11) --- updated-dependencies: - dependency-name: leafo/gh-actions-lua dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [leafo/gh-actions-luarocks](https://github.com/leafo/gh-actions-luarocks) from 4 to 5. - [Release notes](https://github.com/leafo/gh-actions-luarocks/releases) - [Commits](leafo/gh-actions-luarocks@v4...v5) --- updated-dependencies: - dependency-name: leafo/gh-actions-luarocks dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
BreakBB
approved these changes
Dec 18, 2025
Owner
|
Hey @Alessandro-Barbieri this really is a huge rewrite of the buff scanning logic and I am thankful for it! <3 Can I merge it or are there things left to do? |
Owner
Can I leave it to you or are you running out of ideas? I don't have much spare time :( |
Contributor
Author
|
I'll try to investigate more, weakauras solved this issue somehow |
Contributor
Author
|
Ok, it was a stupid mistake by me. Now I think I'm done. |
BreakBB
reviewed
Dec 22, 2025
BreakBB
approved these changes
Dec 23, 2025
Owner
|
Thank you SO MUCH for keeping up the work on this @Alessandro-Barbieri ❤️ It's great you are still so invested into ECS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341 #367