Breaking: Remove AWS Session Manager feature #3236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the AWS Session Manager feature from NETworkManager due to maintenance challenges with the underlying AWS Session Manager Plugin (not actively maintained, keyboard layout bugs) and lack of a test environment. Users can still use AWS Session Manager via the PowerShell feature with the aws ssm start-session command.
Key changes:
- Complete removal of AWS Session Manager feature code, views, and view models
- Removal of AWSSDK.EC2 package dependency
- Documentation updates to reflect the removal and provide alternative usage via PowerShell
- Settings migration logic to handle removal from existing installations
Reviewed Changes
Copilot reviewed 63 out of 65 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/NETworkManager.Models/ApplicationManager.cs | Updated GetDefaultList() to exclude AWSSessionManager, but contains a logic error |
| Website/docs/changelog/next-release.md | Documents the breaking change with migration notes (contains typo) |
| Website/docs/application/aws-session-manager.md | Added deprecation warning with workaround using PowerShell |
| Website/docs/application/powershell.md | Added AWS SSM examples to PowerShell documentation |
| Website/docs/faq/powershell-cmd-apps.md | Added AWS Session Manager example using PowerShell |
| Source/NETworkManager/ViewModels/* | Removed AWS Session Manager view models |
| Source/NETworkManager/Views/* | Removed AWS Session Manager XAML views and code-behind |
| Source/NETworkManager/NETworkManager.csproj | Removed AWSSDK.EC2 package reference |
| Source/NETworkManager.Models/AWS/* | Deleted all AWS-specific model classes |
| Source/NETworkManager.Profiles/* | Removed AWS Session Manager profile properties |
| Source/NETworkManager.Settings/* | Removed AWS Session Manager settings and added upgrade logic |
| Source/NETworkManager.Documentation/* | Removed AWS documentation references and license file |
| Source/NETworkManager.Localization/Resources/* | Removed AWS-related localization strings |
| Source/GlobalAssemblyInfo.cs | Updated assembly version to 2025.11.16.0 |
Files not reviewed (1)
- Source/NETworkManager.Localization/Resources/StaticStrings.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Upgrade your [.NET Desktop Runtime to version 10.0 (LTS) - x64](https://dotnet.microsoft.com/en-us/download/dotnet/10.0/runtime) before you install this version. [#3229](https://github.com/BornToBeRoot/NETworkManager/pull/3229) | ||
|
|
||
| - `AWS Session Manager` feature has been removed. The [AWS Session Manager Plugin](https://github.com/aws/session-manager-plugin) is not actively maintained and contains several bugs (e.g. German / Spain keyboard layout issues). The current code base was also difficult to maintain and extend, and I currently have no test environment. | ||
| The Sync feature (EC2 instances -> Profiles) has been removed as well, because it was limited to AWS Session Manager only. This will be re-introduced in a future release to support multiple proividers (`AWS`, `Azure`, etc.) and more features like `Ping Monitor`, `PuTTY` or `Remote Desktop`. |
There was a problem hiding this comment.
Typo: "proividers" should be "providers"
Owner
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Contributor
|
@BornToBeRoot I've opened a new pull request, #3237, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Fix typo: proividers -> providers in changelog Co-authored-by: BornToBeRoot <16019165+BornToBeRoot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: BornToBeRoot <16019165+BornToBeRoot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request removes all references to AWS Session Manager and the AWSSDK.EC2 library from the documentation and codebase. Additionally, it updates the localization resource file to use German comments and descriptions. The most important changes are grouped below.
Removal of AWS Session Manager and AWSSDK.EC2 references:
ApplicationAWSSessionManagerentry from theDocumentationIdentifierenum and removed related documentation mapping inDocumentationManager.cs. [1] [2]GetIdentifierByApplicationNameandGetIdentifierBySettingsNamemethods. [1] [2]LibraryManager.csand removed its license file from the project. [1] [2] [3] [4]StaticStrings.Designer.cs.Localization and versioning updates:
StaticStrings.Designer.csto German and changed the resource builder version. [1] [2]GlobalAssemblyInfo.csto2025.11.16.0.To-Do
Contributing
By submitting this pull request, I confirm the following: