Skip to content

Conversation

@BornToBeRoot
Copy link
Owner

Changes proposed in this pull request

  • Redesign settings reset dialog

Related issue(s)

Copilot generated summary

Provide a Copilot generated summary of the changes in this pull request.

Copilot summary

This pull request introduces support for a new "Question" icon in the application's child window dialogs, improves the flexibility of dialog view models, and refactors the settings reset dialog to use the new child window infrastructure. The main changes add the new icon type, update the related styles and converters, and refactor dialog presentation to use view models that support icon selection.

Icon Support Improvements

  • Added a new Question value to the ChildWindowIcon enum to support question-style dialogs.
  • Updated the ChildWindowIconToRectangleStyleConverter to handle the new Question icon, returning the appropriate resource.
  • Added a new rectangle style, QuestionImageRectangle, to RectangleStyles.xaml for displaying the question icon.

Dialog and ViewModel Enhancements

  • Updated the OKCancelInfoMessageViewModel to accept an icon parameter and expose an Icon property, allowing dialogs to display different icons based on context. [1] [2]
  • Refactored the OKCancelInfoMessageChildWindow.xaml to use a converter for selecting the icon style based on the view model's Icon property, enabling dynamic icon display. [1] [2]

Settings Dialog Refactor

  • Refactored the settings reset logic to use the new OKCancelInfoMessageChildWindow with the Question icon, improving consistency and user experience for confirmation dialogs.

To-Do

Contributing

By submitting this pull request, I confirm the following:

@mergify mergify bot merged commit fb41d16 into main Aug 10, 2025
4 checks passed
@mergify mergify bot deleted the feature/reset_dialog_redesign branch August 10, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants