Feature: Hide IPv4/6, DNS and DHCP info if adapter is down #3114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request introduces new converters for handling visibility logic based on boolean values, refactors existing converters for clarity, and improves code readability in the
GetNetworkInterfacesmethod. Additionally, it updates XAML files to utilize the new converters.Converter Enhancements:
BooleansAndToVisibilityCollapsedConverterto handle visibility logic where all boolean values must betruefor visibility. (Source/NETworkManager.Converters/BooleansAndToVisibilityCollapsedConverter.cs, Source/NETworkManager.Converters/BooleansAndToVisibilityCollapsedConverter.csR1-R20)BooleanToVisibilityCollapsedMultiConvertertoBooleansOrToVisibilityCollapsedConverterfor clarity and updated its usage in XAML files. (Source/NETworkManager.Converters/BooleansOrToVisibilityCollapsedConverter.cs, [1];Source/NETworkManager/Views/IPScannerView.xaml, [2] [3] [4] [5]Code Readability Improvements:
{}in theGetNetworkInterfacesmethod to improve readability and maintain consistency. (Source/NETworkManager.Models/Network/NetworkInterface.cs, [1] [2] [3]XAML Updates:
BooleansAndToVisibilityCollapsedConverterintoNetworkInterfaceView.xamlfor enhanced visibility logic. (Source/NETworkManager/Views/NetworkInterfaceView.xaml, Source/NETworkManager/Views/NetworkInterfaceView.xamlR29)To-Do
Contributing
By submitting this pull request, I confirm the following: