Skip to content

Conversation

@BornToBeRoot
Copy link
Owner

Changes proposed in this pull request

  • Export dialog redesigned

Copilot generated summary

Provide a Copilot generated summary of the changes in this pull request.

Copilot summary

This pull request introduces a significant refactor across multiple view models in the NETworkManager project. The primary change involves replacing the use of CustomDialog with ExportChildWindow for export functionality, streamlining the code and improving the user interface consistency. Additionally, redundant using directives have been cleaned up, and new ones added where necessary. Below is a summary of the most important changes grouped by theme.

Refactor to use ExportChildWindow:

  • Replaced CustomDialog with ExportChildWindow for export functionality in ExportAction methods across view models, including ARPTableViewModel, BitCalculatorViewModel, ConnectionsViewModel, DNSLookupViewModel, DiscoveryProtocolViewModel, HostsFileEditorViewModel, and IPGeolocationViewModel. This change improves the handling of child windows and ensures proper state management with ConfigurationManager.Current.IsChildWindowOpen. [1] [2] [3] [4] [5] [6] [7]

  • Adjusted the logic for closing child windows and updated the ExportViewModel to reflect the new child window structure. This includes setting childWindow.IsOpen = false after export actions are completed. [1] [2] [3] [4] [5] [6] [7]

Cleanup of using directives:

  • Removed redundant using directives and added MahApps.Metro.SimpleChildWindow where necessary to support the new child window functionality. This cleanup occurred across multiple files, including ProfileDialogManager.cs, ARPTableViewModel.cs, BitCalculatorViewModel.cs, ConnectionsViewModel.cs, DNSLookupViewModel.cs, DiscoveryProtocolViewModel.cs, HostsFileEditorViewModel.cs, and IPGeolocationViewModel.cs. [1] [2] [3] [4] [5] [6] F4be7eaeL1, [7]

Localization update:

  • Added a new localization entry, Entries, to the Strings.resx file to support potential new features or UI elements requiring this text.

To-Do

Contributing

By submitting this pull request, I confirm the following:

@BornToBeRoot BornToBeRoot added this to the next-release milestone Jun 29, 2025
@mergify mergify bot merged commit f486b97 into main Jun 29, 2025
4 checks passed
@mergify mergify bot deleted the feature/export_dialog branch June 29, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants