Feature: Export dialog redesigned #3090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request introduces a significant refactor across multiple view models in the
NETworkManagerproject. The primary change involves replacing the use ofCustomDialogwithExportChildWindowfor export functionality, streamlining the code and improving the user interface consistency. Additionally, redundantusingdirectives have been cleaned up, and new ones added where necessary. Below is a summary of the most important changes grouped by theme.Refactor to use
ExportChildWindow:Replaced
CustomDialogwithExportChildWindowfor export functionality inExportActionmethods across view models, includingARPTableViewModel,BitCalculatorViewModel,ConnectionsViewModel,DNSLookupViewModel,DiscoveryProtocolViewModel,HostsFileEditorViewModel, andIPGeolocationViewModel. This change improves the handling of child windows and ensures proper state management withConfigurationManager.Current.IsChildWindowOpen. [1] [2] [3] [4] [5] [6] [7]Adjusted the logic for closing child windows and updated the
ExportViewModelto reflect the new child window structure. This includes settingchildWindow.IsOpen = falseafter export actions are completed. [1] [2] [3] [4] [5] [6] [7]Cleanup of
usingdirectives:usingdirectives and addedMahApps.Metro.SimpleChildWindowwhere necessary to support the new child window functionality. This cleanup occurred across multiple files, includingProfileDialogManager.cs,ARPTableViewModel.cs,BitCalculatorViewModel.cs,ConnectionsViewModel.cs,DNSLookupViewModel.cs,DiscoveryProtocolViewModel.cs,HostsFileEditorViewModel.cs, andIPGeolocationViewModel.cs. [1] [2] [3] [4] [5] [6] F4be7eaeL1, [7]Localization update:
Entries, to theStrings.resxfile to support potential new features or UI elements requiring this text.To-Do
Contributing
By submitting this pull request, I confirm the following: