Skip to content

Conversation

@BornToBeRoot
Copy link
Owner

Changes proposed in this pull request

  • Redesign group dialog

Related issue(s)

Copilot generated summary

Provide a Copilot generated summary of the changes in this pull request.

Copilot summary

This pull request introduces several changes to enhance code readability and functionality across multiple files in the NETworkManager project. The most significant updates include replacing the GetGroup method with GetGroupByName for improved clarity, refactoring dialog management for group operations, and reordering using directives for consistency.

Method Updates for Group Retrieval:

  • Replaced ProfileManager.GetGroup with ProfileManager.GetGroupByName in multiple CreateSessionInfo methods across files such as AWSSessionManager.cs, PowerShell.cs, PuTTY.cs, RemoteDesktop.cs, SNMP.cs, and TigerVNC.cs. This change improves clarity by explicitly indicating the retrieval is based on the group's name. [1] [2] [3] [4] [5] [6]

Dialog Management Refactor:

  • Simplified dialog management for adding, editing, and deleting groups in ProfileDialogManager.cs. The refactor replaces MetroDialog with ChildWindow for better integration with the application's window hierarchy.
  • Updated calls to ProfileDialogManager.ShowEditGroupDialog in various view models (AWSSessionManagerHostViewModel.cs, DNSLookupHostViewModel.cs, IPGeolocationHostViewModel.cs, IPScannerHostViewModel.cs, NetworkInterfaceViewModel.cs, PingMonitorHostViewModel.cs) to use Application.Current.MainWindow for dialog invocation. [1] [2] [3] [4] [5] [6]

Code Cleanup:

  • Reordered and removed redundant using directives across several files for improved readability and consistency. [1] [2] [3] [4] [5] [6]

These changes collectively enhance code clarity, maintainability, and user interface consistency in the NETworkManager project.

To-Do

Contributing

By submitting this pull request, I confirm the following:

@BornToBeRoot BornToBeRoot merged commit 61670c2 into main Jun 26, 2025
3 of 4 checks passed
@BornToBeRoot BornToBeRoot deleted the feature/group_dialog branch June 26, 2025 23:47
@BornToBeRoot BornToBeRoot added this to the next-release milestone Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use MahApps.ChildWindow for Profile/Group add/edit

2 participants