Feature: DNS Lookup - Support for DNSKEY & SRV added #3060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request introduces several improvements and updates to the DNS Lookup functionality in the
NETworkManagerproject. Key changes include the adoption of a more flexible and readable query type filtering mechanism, the addition of support for new DNS record types, and minor code cleanup and restructuring to enhance maintainability.Enhancements to DNS Lookup Functionality:
ARecords,AaaaRecords) with a more generic and extensible approach usingOfType<T>for processing DNS records. Added support for new record types, includingDNSKEYandSRV. (Source/NETworkManager.Models/Network/DNSLookup.cs, Source/NETworkManager.Models/Network/DNSLookup.csR217-R283)DNSLookup_CustomQueryTypes, inGlobalStaticConfigurationto define a customizable set of query types for DNS lookups. (Source/NETworkManager.Settings/GlobalStaticConfiguration.cs, Source/NETworkManager.Settings/GlobalStaticConfiguration.csR144-R157)Code Simplification and Cleanup:
LoadTypesmethod inDNSLookupViewModelby leveraging the newDNSLookup_CustomQueryTypesproperty and the[..]syntax for creating collections. (Source/NETworkManager/ViewModels/DNSLookupViewModel.cs, Source/NETworkManager/ViewModels/DNSLookupViewModel.csL257-R268)Querywith the[..]syntax for improved readability. (Source/NETworkManager/ViewModels/DNSLookupViewModel.cs, Source/NETworkManager/ViewModels/DNSLookupViewModel.csL340-R341)Dependency and Namespace Management:
usingdirectives across multiple files to remove unused imports and improve clarity. (Source/NETworkManager.Models/Network/DNSLookup.cs, [1];Source/NETworkManager/ViewModels/DNSLookupViewModel.cs, [2] [3]To-Do
Contributing
By submitting this pull request, I confirm the following: