Fix: Use ObservableCollection / avoid multiple calls #3005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request includes several changes to the
NetworkInterfaceViewModelclass in theSource/NETworkManager/ViewModels/NetworkInterfaceViewModel.csfile. The main improvements are the transition fromListtoObservableCollectionfor network interfaces, and the addition of checks to prevent multiple reloads of network interfaces.Changes to data structures and initialization:
_networkInterfacesfromList<NetworkInterfaceInfo>toObservableCollection<NetworkInterfaceInfo>to better support dynamic updates in the UI.NetworkInterfacesproperty to useObservableCollection<NetworkInterfaceInfo>.Improvements to network interface loading:
LoadNetworkInterfacesto add network interfaces directly to theObservableCollectioninstead of replacing the entire collection.ReloadNetworkInterfacesto prevent multiple reloads if a reload is already in progress.ReloadNetworkInterfacesto clear and repopulate theObservableCollectionon the UI thread to ensure thread safety and UI consistency.To-Do
Contributing
By submitting this pull request, I confirm the following: