fix: throw when getExplorerLink has no block explorer URL available#426
Open
gabitoesmiapodo wants to merge 1 commit intotest/utilsfrom
Open
fix: throw when getExplorerLink has no block explorer URL available#426gabitoesmiapodo wants to merge 1 commit intotest/utilsfrom
gabitoesmiapodo wants to merge 1 commit intotest/utilsfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens getExplorerLink by preventing generation of malformed explorer URLs when a chain has no configured block explorer and no explicit explorerUrl is provided.
Changes:
- Extracts a
baseUrlonce and throws when no explorer base URL is available. - Simplifies URL construction for address/tx paths using the extracted
baseUrl. - Adds a Vitest suite covering the new throw behavior and existing URL generation paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/utils/getExplorerLink.ts |
Centralizes explorer base URL selection and throws a clear error when missing. |
src/utils/getExplorerLink.test.ts |
Adds tests for address/tx URL generation, custom explorer override, and missing-explorer error case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
efce7de to
a23f494
Compare
fernandomg
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getExplorerLinkpreviously producedundefined/address/...orundefined/tx/...when called withoutexplorerUrlon a chain that has noblockExplorersconfiguredbaseUrlbefore building the URL and throws'No block explorer URL available for this chain'when neither source provides a URLTest plan
pnpm test src/utils/getExplorerLink.test.ts— 5 tests passexplorerUrl) are unaffectedpnpm buildpasses