-
Notifications
You must be signed in to change notification settings - Fork 12
Busybox #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Busybox #101
Conversation
c9c7fa7 to
b2e352c
Compare
03758c9 to
f6fbf54
Compare
jkloetzke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering what the full enumeration of the allowed CONFIG_INIT values looks like. Obviously, it is at least sysvinit and systemd. I vaguely remember that we discussed that there might be differences between busybox and "full" sysv-init. Would it make sense to allow something like sysvinit/sysv and sysvinit/busybox and match in the recipes to sysvinit/*?
Don't try to make modifications to base files if the user didn't expressed its indent to do so. This removes the defaults of those options.
Done. I added a new "init" class dealing with this. I guess later on for e.g. systemd we will need this anyway. |
jkloetzke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits...
This creates a basic Linux directory/files setup using the merged /usr approach.
Add more options on how the config is gathered. Bring this in line with e.g. the linux kernel, where you could specify a custom package with a defconfig or a busybox defconfig or the standard defconfig. Note, the creation of debugging symbols now depends on the BASEMENT_DEBUG variable. If set, the CONFIG_DEBUG option is set automatically. Also only regenerate the .config if the source config has changed.
Also switch to explicit "if" statements, because otherwise we may miss some errors.
If udhcpc is enabled add a default script which does a basic config.
If the inittab feature is enabled, add a default one.
If enabled put some default init scripts into /etc/init.d.
Add some helper functions for dealing with different init systems. Right now only sysvinit from the sysv and busybox package are supported. Later we will add more, like systemd.
Also add a minimal /etc/network/interfaces file, so that ifupdown is happy when started.
|
Thanks! |
No description provided.