Skip to content

[PW_SID:1035706] [v1] FROMLIST: driver: bluetooth: hci_qca: Always perform cleanup on every setup failure #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BluezTestBot wants to merge 4 commits into
base: workflow
Choose a base branch
from
Open

[PW_SID:1035706] [v1] FROMLIST: driver: bluetooth: hci_qca: Always perform cleanup on every setup failure #3231

BluezTestBot wants to merge 4 commits into from

Conversation

@BluezTestBot
Copy link
Owner

@BluezTestBot BluezTestBot commented Dec 22, 2025

The retry logic in qca_setup combined error handling and
retry gating under a single condition. This caused the final failed
attempt (when retries reached MAX_INIT_RETRIES) to return without
performing cleanup.

So only jumping to retry when there is a error and retries have not
reached MAX_INIT_RETRIES.

Signed-off-by: jinwli jinwang.li@oss.qualcomm.com

drivers/bluetooth/hci_qca.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

bhavani-oss-source and others added 4 commits December 18, 2025 14:16
@bhavani-oss-source @Vudentz
Bluetooth: hci_sync: Add LE Channel Sounding HCI Command/event struct…
a078240 
…ures

1. Implement LE Event Mask to include events required for
   LE Channel Sounding
2. Enable Channel Sounding feature bit in the
   LE Host Supported Features command
3. Define HCI command and event structures necessary for
   LE Channel Sounding functionality

Signed-off-by: Naga Bhavani Akella <naga.akella@oss.qualcomm.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
@Vudentz
Bluetooth: L2CAP: Add support for setting BT_PHY
9824693 
This enables client to use setsockopt(BT_PHY) to set the connection
packet type/PHY:

Example setting BT_PHY_BR_1M_1SLOT:

< HCI Command: Change Conne.. (0x01|0x000f) plen 4
        Handle: 1 Address: 00:AA:01:01:00:00 (Intel Corporation)
        Packet type: 0x331e
          2-DH1 may not be used
          3-DH1 may not be used
          DM1 may be used
          DH1 may be used
          2-DH3 may not be used
          3-DH3 may not be used
          2-DH5 may not be used
          3-DH5 may not be used
> HCI Event: Command Status (0x0f) plen 4
      Change Connection Packet Type (0x01|0x000f) ncmd 1
        Status: Success (0x00)
> HCI Event: Connection Packet Typ.. (0x1d) plen 5
        Status: Success (0x00)
        Handle: 1 Address: 00:AA:01:01:00:00 (Intel Corporation)
        Packet type: 0x331e
          2-DH1 may not be used
          3-DH1 may not be used
          DM1 may be used
          DH1 may be used
          2-DH3 may not be used
          3-DH3 may not be used
          2-DH5 may not be used

Example setting BT_PHY_LE_1M_TX and BT_PHY_LE_1M_RX:

< HCI Command: LE Set PHY (0x08|0x0032) plen 7
        Handle: 1 Address: 00:AA:01:01:00:00 (Intel Corporation)
        All PHYs preference: 0x00
        TX PHYs preference: 0x01
          LE 1M
        RX PHYs preference: 0x01
          LE 1M
        PHY options preference: Reserved (0x0000)
> HCI Event: Command Status (0x0f) plen 4
      LE Set PHY (0x08|0x0032) ncmd 1
        Status: Success (0x00)
> HCI Event: LE Meta Event (0x3e) plen 6
      LE PHY Update Complete (0x0c)
        Status: Success (0x00)
        Handle: 1 Address: 00:AA:01:01:00:00 (Intel Corporation)
        TX PHY: LE 1M (0x01)
        RX PHY: LE 1M (0x01)

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
@tedd-an
workflow: Add workflow files for ci
8eabaf6 
This patch adds workflow files for ci:

[sync.yml]
 - The workflow file for scheduled work
 - Sync the repo with upstream repo and rebase the workflow branch
 - Review the patches in the patchwork and creates the PR if needed

[ci.yml]
 - The workflow file for CI tasks
 - Run CI tests when PR is created

Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
@tedd-an
FROMLIST: driver: bluetooth: hci_qca: Always perform cleanup on every…
0e44ac1 
… setup failure

The retry logic in qca_setup combined error handling and
retry gating under a single condition. This caused the final failed
attempt (when retries reached MAX_INIT_RETRIES) to return without
performing cleanup.

So only jumping to retry when there is a error and retries have not
reached MAX_INIT_RETRIES.

Signed-off-by: jinwli <jinwang.li@oss.qualcomm.com>
@github-actions
Copy link

github-actions bot commented Dec 22, 2025

CheckPatch
Desc: Run checkpatch.pl script
Duration: 0.41 seconds
Result: PENDING

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

GitLint
Desc: Run gitlint
Duration: 0.38 seconds
Result: PENDING

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

SubjectPrefix
Desc: Check subject contains "Bluetooth" prefix
Duration: 0.42 seconds
Result: FAIL
Output:

"Bluetooth: " prefix is not specified in the subject

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

BuildKernel
Desc: Build Kernel for Bluetooth
Duration: 23.79 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

CheckAllWarning
Desc: Run linux kernel with all warning enabled
Duration: 26.01 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

CheckSparse
Desc: Run sparse tool with linux kernel
Duration: 28.72 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

BuildKernel32
Desc: Build 32bit Kernel for Bluetooth
Duration: 23.42 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunnerSetup
Desc: Setup kernel and bluez for test-runner
Duration: 512.69 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_l2cap-tester
Desc: Run l2cap-tester with test-runner
Duration: 28.69 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_iso-tester
Desc: Run iso-tester with test-runner
Duration: 68.25 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_bnep-tester
Desc: Run bnep-tester with test-runner
Duration: 6.29 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_mgmt-tester
Desc: Run mgmt-tester with test-runner
Duration: 122.41 seconds
Result: FAIL
Output:

Total: 494, Passed: 487 (98.6%), Failed: 3, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.110 seconds
LL Privacy - Add Device 2 (2 Devices to AL)          Failed       0.174 seconds
LL Privacy - Set Flags 3 (2 Devices to RL)           Failed       0.175 seconds

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_rfcomm-tester
Desc: Run rfcomm-tester with test-runner
Duration: 9.45 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_sco-tester
Desc: Run sco-tester with test-runner
Duration: 14.59 seconds
Result: FAIL
Output:

WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_ioctl-tester
Desc: Run ioctl-tester with test-runner
Duration: 10.08 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_mesh-tester
Desc: Run mesh-tester with test-runner
Duration: 11.51 seconds
Result: FAIL
Output:

Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    1.851 seconds
Mesh - Send cancel - 2                               Timed out    1.996 seconds

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_smp-tester
Desc: Run smp-tester with test-runner
Duration: 8.58 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

TestRunner_userchan-tester
Desc: Run userchan-tester with test-runner
Duration: 6.70 seconds
Result: PASS

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

IncrementalBuild
Desc: Incremental build with the patches in the series
Duration: 0.80 seconds
Result: PENDING

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BluezTestBot @bhavani-oss-source @Vudentz @tedd-an