BUG: Compute Euclidean Dist Map now does not create extra arrays. #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykleingers
force-pushed
the
bugfix/ComputeEuclideanDistMap
branch
from
c3f7db9 to
29d9e9b
Compare
Contributor
|
@joeykleingers Do you think we need an updated unit test for this? Not sure if we need new data files but do we need variations on the parameters to ensure the filter is at least producing the expected results? |
imikejackson
changed the title
imikejackson
force-pushed
the
bugfix/ComputeEuclideanDistMap
branch
from
b21e1d1 to
fa131fa
Compare
joeykleingers
force-pushed
the
bugfix/ComputeEuclideanDistMap
branch
3 times, most recently
from
5de0e3c to
977d69a
Compare
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
…l arguments This cuts down on the if-conditional logic to figure out which output array to use.
Also use int64 for nearest neighbors vector. Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
imikejackson
force-pushed
the
bugfix/ComputeEuclideanDistMap
branch
from
1113d3f to
6bd296f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.