BUG: Fixes bugs and refactors code in GroupMicrotextureRegions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
force-pushed
the
topic/group_mtr_regions_fixes
branch
4 times, most recently
from
6ce723a to
d0723d7
Compare
imikejackson
force-pushed
the
topic/group_mtr_regions_fixes
branch
3 times, most recently
from
64ff34a to
e623f27
Compare
imikejackson
force-pushed
the
develop
branch
from
1fae72c to
2b33dd8
Compare
imikejackson
force-pushed
the
topic/group_mtr_regions_fixes
branch
4 times, most recently
from
c5863ce to
d1ffdb7
Compare
imikejackson
force-pushed
the
topic/group_mtr_regions_fixes
branch
2 times, most recently
from
274aeb6 to
98809b4
Compare
* Forced random seed to `std::mt19937::default_seed` * Randomized ParentIds is disabled * Ensure Use Running Average is enabled
imikejackson
force-pushed
the
topic/group_mtr_regions_fixes
branch
from
98809b4 to
dd24ff5
Compare
There are necessary changes on the DREAM.3D 6.5.172 or newer to remove randomness and fix other bugs. Both DREAM3D-NX 7 and DREAM.3D 6.5.172 output identical results.
Added a missing check for non-contiguous neighbors which would have caused a crash Added a check for valid 'execute()' before continuing Used EbsdLib::Matrix3x3 for more consistent matrix usage.
- No unit test yet - No idea what data set to use for a unit test - Docs have been updated
imikejackson
force-pushed
the
topic/group_mtr_regions_fixes
branch
from
39b2025 to
c1b70f6
Compare
imikejackson
force-pushed
the
develop
branch
from
a197a94 to
28aad27
Compare
imikejackson
force-pushed
the
topic/group_mtr_regions_fixes
branch
from
c1b70f6 to
39b2025
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/SimplnxReview/Filters/Algorithms/GroupMicroTextureRegions.cpp
Outdated
Show resolved
Hide resolved
src/SimplnxReview/Filters/Algorithms/GroupMicroTextureRegions.cpp
Outdated
Show resolved
Hide resolved
src/SimplnxReview/Filters/Algorithms/GroupMicroTextureRegions.cpp
Outdated
Show resolved
Hide resolved
imikejackson
force-pushed
the
topic/group_mtr_regions_fixes
branch
from
0edcd13 to
62f904e
Compare
imikejackson
force-pushed
the
topic/group_mtr_regions_fixes
branch
from
df2474c to
57829b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.