BUG: Fix bugs inside of the _calcRodNearestOrigin function. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier commit from Nov 2025 changed the RodSym values to 4 component values but that function still assumed it was a 3 component Rodrigues Orientation.
JDuffeyBQ
reviewed
Jan 12, 2026
JDuffeyBQ
reviewed
Jan 14, 2026
Co-authored-by: Jared Duffey <jared.duffey@bluequartz.net>
JDuffeyBQ
approved these changes
Jan 16, 2026
imikejackson
added a commit
to imikejackson/EbsdLib
that referenced
this pull request
Jan 16, 2026
…tzSoftware#36) * BUG: Fix bugs inside of the _calcRodNearestOrigin function. Earlier commit from Nov 2025 changed the RodSym values to 4 component values but that function still assumed it was a 3 component Rodrigues Orientation. * Update some static constants to constexpr * COMP: Remove legacy float[3][3] for MatSymOp functions * ENH: Update more functions, static constants, formatting and other bits --------- Co-authored-by: Jared Duffey <jared.duffey@bluequartz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier commit from Nov 2025 changed the RodSym values to 4 component values but that function still assumed it was a 3 component Rodrigues Orientation.