Open
Conversation
- Allow SLA to provide vTarget to ICBM when in preActive state - Breaks circular dependency: SLA preActive -> ICBM adjusts cluster -> SLA becomes active - Only affects non-PCM vehicles (ICBM-enabled brands like Ford, Mazda, etc.) - Resolves issue where SLA would timeout in preActive state waiting for cluster adjustment Fixes: Speed Limit Assist not working with Ford ICBM implementation
- Test verifies ICBM vehicles get vTarget in preActive state - Ensures PCM vehicle behavior remains unchanged - Validates edge cases (no speed limit, disabled state) - Confirms fix resolves Ford ICBM + Speed Limit Assist integration
- Allow ICBM vehicles to get speed targets in preActive state - Breaks circular dependency: SLA preActive -> ICBM adjusts cluster -> SLA active - Add comprehensive test coverage for ICBM-specific behavior - Maintains backward compatibility for non-ICBM vehicles This specifically addresses the Ford F-150 ICBM issue where Speed Limit Assist cannot activate due to a circular dependency. ICBM needs the speed target to adjust cluster speed, but SLA won't provide targets until active. This fix allows ICBM vehicles to get targets in preActive state, breaking the cycle. Fixes: Ford F-150 ICBM unable to work with Speed Limit Assist Addresses: https://community.sunnypilot.ai/t/ford-icbm-wip-discussion/1392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.