Skip to content

Add LaserDetection message for tracked laser output#267

Merged
jp-pino merged 5 commits into
masterfrom
jp-pino/laser
Jun 2, 2026
Merged

Add LaserDetection message for tracked laser output#267
jp-pino merged 5 commits into
masterfrom
jp-pino/laser

Conversation

@jp-pino
Copy link
Copy Markdown
Contributor

@jp-pino jp-pino commented May 22, 2026

This pull request extends the protobuf message definitions to support new computer vision features related to laser detection, specifically for the Ultra model. It introduces new messages for representing 2D points and laser detection results, and updates telemetry to include detection data.

Additions for laser detection and telemetry:

  • protobuf_definitions/message_formats.proto:
    • Added the modulated boolean field to the Laser message to indicate if the laser is modulated at 5Hz for tracking.
    • Introduced the Point2D message for representing 2D coordinates.
    • Added the LaserDetection message to encapsulate detected laser dot centroids, their pixel distance, detection confidence, and source image dimensions, supporting new computer vision features.

Telemetry enhancements:

  • protobuf_definitions/telemetry.proto:
    • Updated the LaserTel message to include a laser_detection field, reporting computer vision-based laser detection status and details.

@jp-pino jp-pino added this to the Blunux v5.0 milestone May 22, 2026
@jp-pino jp-pino requested review from Copilot and follesoe May 22, 2026 09:05
@jp-pino jp-pino self-assigned this May 22, 2026
@jp-pino jp-pino added the enhancement New feature or request label May 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the public protobuf schema to support Ultra-specific computer-vision laser tracking by adding a laser modulation flag, introducing new 2D/detection message types, and exposing detection results via telemetry.

Changes:

  • Added modulated to Laser to indicate 5 Hz modulation for CV tracking (Ultra-only).
  • Introduced Point2D and LaserDetection messages to represent detected dot centroids and related metadata.
  • Extended LaserTel telemetry to include laser_detection.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
protobuf_definitions/message_formats.proto Adds Laser.modulated plus new Point2D/LaserDetection message definitions for CV laser tracking.
protobuf_definitions/telemetry.proto Adds LaserDetection to LaserTel telemetry to report CV laser detection results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread protobuf_definitions/message_formats.proto Outdated
jp-pino and others added 2 commits May 22, 2026 11:09
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@follesoe follesoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to consider (not sure if we need it or not) is if we should return the width of the laser in the telemetry, so that the messages are cohesive in themself? If not, consumer of the telemetry/log data needs to check the device ID of the connected laser, and then maintain a look up table with the device id <-> laser width.

This might be nice to have in libblunux, and expose. The draw back, is that this is static data so wastefull to include in every telemetry message.

🤔

@jp-pino jp-pino merged commit 2ad7db6 into master Jun 2, 2026
4 checks passed
@jp-pino jp-pino deleted the jp-pino/laser branch June 2, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants