Skip to content

Conversation

@roconnor-blockstream
Copy link
Contributor

No description provided.

roconnor-blockstream added a commit to roconnor-blockstream/simplicity-lang-org that referenced this pull request Oct 24, 2025
roconnor-blockstream added a commit to roconnor-blockstream/simplicitytxtool that referenced this pull request Oct 24, 2025
@apoelstra
Copy link
Contributor

Does not compile with latest nightly -- there is a recent rustc change to remove doc_auto_cfg from the compiler. I will try to add a commit removing this from your PR, or you can do it if you're online (in fact, Github will not let me ACK if I'm the last pusher so I'd prefer you did).

@apoelstra
Copy link
Contributor

Actually we may just be fucked, at least for a while. We depend on Miniscript 12 which depends on bitcoin 0.32 which depends on secp 0.29 which depends on rand 0.8 which depends on rand_chacha 0.3 which depends on rand_core 0.6 which depends on getrandom 0.2 which the Rust compiler developers broke compilation of a couple weeks ago.

@apoelstra
Copy link
Contributor

apoelstra commented Oct 25, 2025

rust-lang/rust#138907

apoelstra added a commit that referenced this pull request Dec 1, 2025
66e1a6a remove use of deprecated encoding function (Andrew Poelstra)
67720ab SimplicityHl: use released version 0.3 (Andrew Poelstra)
6715eb1 SimplicityHL: use released version 0.2 (Andrew Poelstra)
12c7daf clippy: turn on a bunch of pedantic lints (Andrew Poelstra)
1858e6d clippy: fix a bunch of "trivial" lints (Andrew Poelstra)
ab54fed delete merkle.rs and unused supporting code (Andrew Poelstra)
837cb9c Define a MSRV of 1.78.0 (Andrew Poelstra)

Pull request description:

  Should unblock #56 
  
  After this and #56 we should cut a new release and attempt to update the production site.


ACKs for top commit:
  delta1:
    ACK 66e1a6a; ran cargo test locally 


Tree-SHA512: a978c947e4eeef2a9c341cef0a4d41891ced5c3aabb35ec415ba35d68da30ef5301d520be0da32958bb28e57f16c9888a4101a722d184c6dd9ad5ca775f1e9fe
apoelstra
apoelstra previously approved these changes Dec 1, 2025
Copy link
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7af8ef0; successfully ran local tests

@apoelstra
Copy link
Contributor

@roconnor-blockstream can you rebase this on master?

@roconnor-blockstream
Copy link
Contributor Author

Do I need to message you by typing this after I rebase?

@apoelstra
Copy link
Contributor

No, but it helps, thanks!

Copy link
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e7a0c89; successfully ran local tests

@apoelstra apoelstra merged commit 15a9df6 into BlockstreamResearch:master Dec 3, 2025
2 checks passed
@roconnor-blockstream roconnor-blockstream deleted the patch-2 branch December 3, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants