🐛 Option issue#21

[LesterEvSe]

No description provided.

[apoelstra]

3db6ee9 adds a unit test but also weakens the code (I guess because the unit test would be impossible otherwise, and actually the contract is secure?)

For e2621fe see my comments on #21 -- I think (though I didn't try) that you can significantly simplify this code. Having said this, I'm still confused as to why we are working with confidential assets at all. The contract code should have a detailed comment explaining this.

609873b is a merge commit (and a merge commit with nontrivial changes in it).

[LesterEvSe]

3db6ee9 adds a unit test but also weakens the code (I guess because the unit test would be impossible otherwise, and actually the contract is secure?)

Yes, you understood correctly. The reason is described in this comment. This removes the hard coding.

For e2621fe see my comments on #21 -- I think (though I didn't try) that you can significantly simplify this code. Having said this, I'm still confused as to why we are working with confidential assets at all. The contract code should have a detailed comment explaining this.

Okay, after reading roconnor's and your comments, I made some improvements to the code. I also added an explanation of why confidential assets are needed and referred to roconnor's explanation here.