Use deserialize_hex to avoid intermediate Vec allocation#205
Open
EddieHouston wants to merge 2 commits intoBlockstream:new-indexfrom
Open
Use deserialize_hex to avoid intermediate Vec allocation#205EddieHouston wants to merge 2 commits intoBlockstream:new-indexfrom
EddieHouston wants to merge 2 commits intoBlockstream:new-indexfrom
Conversation
bitcoin 0.32 provides deserialize_hex which parses hex directly into the target type without allocating an intermediate Vec<u8>. The elements crate (0.26) doesn't expose this yet, so liquid builds keep the two-step FromHex + deserialize path behind a cfg gate.
RCasatta
previously approved these changes
Apr 8, 2026
…y which type (Block, Transaction, BlockHeader) failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitcoin::consensus::encode::deserialize_hex(available since bitcoin 0.32) inheader_from_value,block_from_value, andtx_from_valueto parse hex directly into the target type without allocating an intermediateVec<u8>elementscrate (0.26) doesn't exposedeserialize_hexyet, so liquid builds keep the two-stepFromHex+deserializepath behind a cfg gatedeserialize_hexwhen upgrading version #94