Add input paths to config file #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadyChristina
requested review from
ZeeshanJan and
Copilot
and removed request for
dimkarakostas
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new configuration parameter for specifying input directories for raw block data and updates the parsing, mapping, data-collection, and execution modules to use a list of directories instead of a single directory.
- Updated parser, mapping, and helper modules to accept a list of input directories.
- Replaced direct references to RAW_DATA_DIR with get_input_directories() in tests, run.py, and data collection scripts.
- Updated constructors and function signatures across the codebase to use “ledger” and “input_dirs” consistently.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_parsers.py | Replaced RAW_DATA_DIR with get_input_directories() and updated corresponding variable names and assignments. |
| tests/test_mappings.py | Adjusted parameters to use input_dirs in mapping tests. |
| run.py | Modified processing to use get_input_directories() and added error handling for missing raw data files. |
| data_collection_scripts/collect_block_data.py | Changed parameter passing from RAW_DATA_DIR to a received raw_data_dir parameter from get_input_directories(). |
| consensus_decentralization/parsers/{ethereum,dummy,default}_parser.py | Updated constructor signatures and file retrieval methods for handling multiple input directories. |
| consensus_decentralization/parse.py | Updated parameter names and logging to reflect the new ledger and input_dirs usage. |
| consensus_decentralization/helper.py | Removed RAW_DATA_DIR and introduced get_input_directories() to fetch raw data paths from the config. |
| config.yaml | Added a new configuration key “input_directories” with a default path. |
Contributor
|
LGTM. |
ZeeshanJan
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Description
Added new parameter to config file that specifies where to look for the raw block data. The value is a list of (relative) paths, so this allows us to have the raw data of different ledgers in different directories if needed.