Fix Config Race Condition and Logger Split-Brain #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses critical concurrency issues in the configuration and logging subsystems.
Configuration Fixes
Configstruct ininternal/config/config.gowas vulnerable to data races where fields were read while being written (e.g., by the orchestrator).sync.RWMutexto theConfigstruct. All method implementations of theInterface(Getters and Setters) now strictly useRLock()andLock()respectively to ensure thread safety.Logger Fixes
GetLogger()was called beforeInitialize(), the caller received a fallback logger and would hold onto it indefinitely, ignoring the subsequent initialization.GetLogger()now returns a stable singletonproxyLoggerbacked by aproxyCore. This core delegates dynamically to the underlyingglobalLogger, ensuring that whenInitialize()runs, all existing references effectively "hot-swap" to the new configuration.ResetForTestfunction was overwriting async.Oncevalue, which is unsafe.sync.Oncewithatomic.Pointer[sync.Once], allowing safe and atomic resetting of initialization state for tests.Verification
pkg/observabilityto verify the proxy behavior and initialization logic.internal/config(failures unrelated to these changes were noted but out of scope).PR created automatically by Jules for task 3017510955809941058 started by @xkilldash9x