ci: test for node nightly compat + dependency fixes#8374
Open
roshan-bitgo wants to merge 5 commits intomasterfrom
Open
ci: test for node nightly compat + dependency fixes#8374roshan-bitgo wants to merge 5 commits intomasterfrom
roshan-bitgo wants to merge 5 commits intomasterfrom
Conversation
react-json-view-lite imports a plain .css file which webpack could not process as only .scss was handled. Add css-loader rules to both dev and prod webpack configs. TICKET: VL-5111
The yarn alias html-webpack-plugin-5@npm:html-webpack-plugin@^5 resolved to 5.6.6 in the lockfile. The dependency-age-check tool looks up html-webpack-plugin-5@5.6.6 on npm, which returns unusual registry metadata that the tool cannot parse, causing the cooldown CI job to fail deterministically. Adds html-webpack-plugin-5 to resolutions to prevent future re-upgrades, and pins the lockfile entry to 5.6.4 (matching the existing html-webpack-plugin pin added for the same reason). TICKET: VL-5111
The root resolutions block still pinned @types/react and @types/react-dom to 17.x. Yarn deduped both the 17.x pin and the new ^18.0.0 devDep from web-demo into a single lockfile entry resolving to 17.0.16. npm then found 17.0.16 in the tree while web-demo declared ^18.0.0, causing ERESOLVE on the new npm-install-compatibility CI job. Bumps the resolutions pins to ^18.0.0 and splits the yarn lockfile entries so ^18.0.0 resolves to 18.3.7 / 18.3.28. TICKET: VL-5111
roshan-bitgo
changed the title
In @types/react@18, FunctionComponent no longer implicitly includes children in props. Explicitly type Layout with React.PropsWithChildren to restore the previous behavior. TICKET: VL-5111
bhargavirao24
approved these changes
Mar 29, 2026
bhargavirao24
left a comment
bhargavirao24
left a comment
There was a problem hiding this comment.
I am approving these changes. They are code-red fixes and take precedence over dependency-review concerns
louib
approved these changes
Mar 29, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm-install-compatibilityCI job that runsnpm installagainst Node.js v25.8.2 (latest stable) and v26-nightly, to catch peer dep and resolution issues before they reach mastermodules/web-demofrom React 17 → 18 types,react-json-view→react-json-view-lite,@cypress/reactv8 → v9web-demowebpack config for.cssimports introduced byreact-json-view-liteoverridesforhandlebars,path-to-regexp(security fixes), and React 18 types@types/react/@types/react-domresolution: rootresolutionsblock still pinned both to 17.x; yarn deduped the^18.0.0web-demo devDep into the 17.x lockfile entry, causingnpm installto ERESOLVE. Bumps resolutions pins to^18.0.0and splits the lockfile entries so^18.0.0correctly resolves to18.3.7/18.3.28.html-webpack-plugin-5cooldown check: the yarn aliashtml-webpack-plugin-5@npm:html-webpack-plugin@^5was resolving to5.6.6, which has malformed npm registry metadata that causes the dependency-age-check tool to fail with a JSON parse error. Pins the alias to5.6.4in both resolutions and lockfile.Linear: VL-5111