feat(sdk-api): add registerToken method to BitGoAPI#8367
Open
manas-at-bitgo wants to merge 1 commit intomasterfrom
Open
feat(sdk-api): add registerToken method to BitGoAPI#8367manas-at-bitgo wants to merge 1 commit intomasterfrom
manas-at-bitgo wants to merge 1 commit intomasterfrom
Conversation
manas-at-bitgo
force-pushed
the
feat/ams-register-token-cshld-89
branch
2 times, most recently
from
6b64045 to
c326748
Compare
Adds a `registerToken(coinConfig, coinConstructor)` method to `BitGoAPI` that delegates to `GlobalCoinFactory.registerToken`. Enables runtime registration of AMS-sourced tokens without requiring statics library updates. Method is idempotent and does not affect existing statics coins. Closes CSHLD-89
manas-at-bitgo
force-pushed
the
feat/ams-register-token-cshld-89
branch
from
c326748 to
a6a1ca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerToken(coinConfig, coinConstructor)method toBitGoAPIinmodules/sdk-api/src/bitgoAPI.tsGlobalCoinFactory.registerToken— idempotent, does not affect existing statics coinsParameters<CoinFactory['registerToken']>[0]for the coin config type (no new direct dep on@bitgo/statics)Test plan
sdk.coin(name)resolves correctly afterregisterTokenregisterTokentwice for the same token does not throw (idempotency)registerTokencallsCloses CSHLD-89