Skip to content

feat(canton): return extended payload from signablePayload #8337

Draft
derranW26 wants to merge 1 commit intomasterfrom
WP-8187-investigate-txintentmismatch-for-canton
Draft

feat(canton): return extended payload from signablePayload #8337
derranW26 wants to merge 1 commit intomasterfrom
WP-8187-investigate-txintentmismatch-for-canton

Conversation

@derranW26
Copy link
Copy Markdown

@derranW26 derranW26 commented Mar 23, 2026

Ticket: WP-8187

@derranW26 derranW26 force-pushed the WP-8187-investigate-txintentmismatch-for-canton branch 3 times, most recently from d5c7249 to 0621452 Compare March 23, 2026 20:39
@derranW26 derranW26 marked this pull request as ready for review March 24, 2026 14:23
@derranW26 derranW26 requested a review from a team as a code owner March 24, 2026 14:23
@derranW26 derranW26 marked this pull request as draft March 24, 2026 16:27
@sachushaji
Copy link
Copy Markdown
Contributor

@claude

@derranW26 derranW26 marked this pull request as ready for review March 29, 2026 01:43
@derranW26 derranW26 marked this pull request as draft March 29, 2026 01:44
@derranW26 derranW26 force-pushed the WP-8187-investigate-txintentmismatch-for-canton branch from 0621452 to 8b0cbf7 Compare March 30, 2026 14:37
@derranW26 derranW26 changed the title feat(canton): implement getSignablePayload override for EdDSA extended payload feat(canton): return extended payload from signablePayload Mar 30, 2026
Override signablePayload in Transaction and WalletInitTransaction
to return the full extended binary payload (transaction metadata +
hash) instead of just the raw hash. This ensures signableHex
matches what the HSM signs, fixing TxIntentMismatch errors.

Ticket: WP-8187
@derranW26 derranW26 force-pushed the WP-8187-investigate-txintentmismatch-for-canton branch from 8b0cbf7 to 3bdc436 Compare March 30, 2026 14:46
@sachushaji
Copy link
Copy Markdown
Contributor

@claude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants