-
Notifications
You must be signed in to change notification settings - Fork 300
feat(statics): change kava to new cosmos structure #7941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| name = 'Kava'; | ||
| family = CoinFamily.KAVA; | ||
| explorerUrl = 'https://www.mintscan.io/kava/transactions/'; | ||
| addressPrefix = 'kava'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide the source of these values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values come from coin sandboxing report for kava, here is the PR for the same: coin-sandbox-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general practice, first get approval and merge the sandbox pr before raising the statics PR.
modules/statics/src/networks.ts
Outdated
| class Kava extends Mainnet implements CosmosNetwork { | ||
| name = 'Kava'; | ||
| family = CoinFamily.KAVA; | ||
| explorerUrl = 'https://www.mintscan.io/kava/transactions/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explorer endpoints will also change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kava explorer URLs are as follows:
Mainnet: https://www.mintscan.io/kava/tx/ — for Cosmos-native Kava transactions
Testnet: https://testnet.mintscan.io/kava-testnet/tx/ — for testnet transactions
Changed to above
592acd1 to
8fc8dbf
Compare
8fc8dbf to
e0a31d9
Compare
TICKET: COIN-7315