fix(sdk-coin-ada): token verifytransaction #7940
Draft
+230
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarath
changed the title
Ranjna-G
reviewed
Jan 20, 2026
| throw new Error('cannot find recipient in expected output'); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Can we please add the consolidation IF case as well so that we do not have to remember this touchpoint in single asset consolidation of tokens?
Ranjna-G
reviewed
Jan 20, 2026
| const txJson = transaction.toJson(); | ||
|
|
||
| if (txParams.recipients !== undefined) { | ||
| const policyScriptHash = CardanoWasm.ScriptHash.from_hex(this.tokenConfig.policyId); |
Contributor
There was a problem hiding this comment.
This policyId might have the encoded asset name as the suffix whereas the output.assets might have just the policy id, can we ensure this case is handled ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: COIN-7292