feat(sdk-core, abstract-utxo): enhance explainTransaction with wallet context #7932
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow passing wallet instance to explainTransaction for additional context during transaction validation. This enables more accurate verification of staking transactions by providing wallet-specific information. Issue: BTC-2963 Co-authored-by: llm-git <llm-git@ttll.de>
Allow explainTransaction to automatically fetch keychains when none are provided but a wallet is available. Issue: BTC-2963 Co-authored-by: llm-git <llm-git@ttll.de>
Contributor
Author
|
note: audit failure is unrelated to this PR |
davidkaplanbitgo
approved these changes
Jan 20, 2026
alextse-bg
approved these changes
Jan 20, 2026
Is this being handled separately? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the explainTransaction functionality across two packages:
sdk-core: Adds ability to pass wallet instance to explainTransaction for
additional context during transaction validation. This enables more accurate
verification of staking transactions by providing wallet-specific
information.
abstract-utxo: Adds automatic keychain fetching in explainTransaction when
a wallet is available but no keychains are explicitly provided.
These changes improve transaction validation by leveraging available wallet
context.
Issue: BTC-2963