Merged
Conversation
Collaborator
|
tACK, kind of works :) hard to test without --preseed. |
NickeZ
approved these changes
Apr 1, 2026
NickeZ
reviewed
Apr 1, 2026
NickeZ
requested changes
Apr 1, 2026
Collaborator
NickeZ
left a comment
NickeZ
left a comment
There was a problem hiding this comment.
Actually, can we discuss LvTimer? Why is that needed?
We already have a delay implementation that works for simulators and should be moved to the right place.
And for the stm32u5 platform we will use an STM HAL Timer.
NickeZ
reviewed
Apr 2, 2026
Add a Timer interface to bitbox-hal and pass timer handles into startup and UI flows instead of calling device-local delay modules. Move the simulator thread-based timer implementation into bitbox-platform-host, remove the old bitbox02 and bitbox03 delay modules, and drop the leftover LVGL timer wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.