Eth: Add payment request support for EIP1559#162
Merged
cedwies merged 3 commits intoBitBoxSwiss:masterfrom Apr 2, 2026
Merged
Conversation
cedwies
force-pushed
the
cedwies/coin-purchase-memo
branch
from
cbec16e to
7231f9c
Compare
benma
reviewed
Feb 26, 2026
api/firmware/paymentrequests_test.go
Outdated
| @@ -0,0 +1,48 @@ | |||
| package firmware | |||
api/firmware/paymentrequests_test.go
Outdated
Comment on lines
+11
to
+12
| // TODO: Add integration test for CoinPurchaseMemo once the firmware UI is implemented. | ||
| // potentially in psbt_test.go |
Contributor
There was a problem hiding this comment.
Please no TODOs in code, they very often get missed or stay forever. Keep track of TODOs in issue trackers instead.
In this case it might be most practical to wait with review&merge of this PR until this can be addressed.
Collaborator
Author
|
Makes sense. I will put this in Draft until it's a good time to resume. |
cedwies
force-pushed
the
cedwies/coin-purchase-memo
branch
from
7231f9c to
8be5c62
Compare
cedwies
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.