[WIP] tests: schedule Playwright across released simulators and use latest on PRs#3976
Closed
bznein wants to merge 2 commits intoBitBoxSwiss:masterfrom
Closed
[WIP] tests: schedule Playwright across released simulators and use latest on PRs#3976bznein wants to merge 2 commits intoBitBoxSwiss:masterfrom
bznein wants to merge 2 commits intoBitBoxSwiss:masterfrom
Conversation
As we release more simulators, it'd be nice to run tests on all released versions. However, doing so on every PR can slow down things: while tests would be independent and parallel, we might still have to wait for github to release enough runners. And eventual flakes would cause delays in retrying.
Runs on all simulator are scheduled at midnight on master, for the PR tests we use the latest released simulator.
Collaborator
Author
|
This fails terribly :) not ready for review until I figure out why :) |
bznein
changed the title
Collaborator
Author
|
Closing, will resume this work after swapkit with a new approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbackend/devices/bitbox02/testdata/ simulators.jsonv9.24.0onward
push/pull_requestPlaywright runs to a single simulator, but switch thatsimulator to the latest released version in
simulators.jsonWhy
Before asking for reviews, here is a check list of the most common things you might need to consider: