Frontend/swap account selection#3954
Closed
bznein wants to merge 52 commits intoBitBoxSwiss:staging-swapfrom
Closed
Frontend/swap account selection#3954bznein wants to merge 52 commits intoBitBoxSwiss:staging-swapfrom
bznein wants to merge 52 commits intoBitBoxSwiss:staging-swapfrom
Conversation
If we return the unmarshaling error, the fronted might show the user an error that is confusing and not helpful. By returning the actual error, there is a change the user might figure out what's wrong on their own. And even if they don't, it would be easier for support to troubleshoot.
5 tasks
bznein
force-pushed
the
frontend/swap-account-selection
branch
from
e7573ab to
83ef05d
Compare
Drop the unnecessary vi.importActual call in tests. These mocks were starting async module loads from synchronous mock factories without awaiting them, which could leave a Vite module fetch pending during worker shutdown and intermittently fail CI.
bznein
force-pushed
the
frontend/swap-account-selection
branch
5 times, most recently
from
87c9709 to
ab3ea61
Compare
Keep zero-value chart history when there was account activity, so My Portfolio does not appear empty after funds were received and later sent out within the same chart interval.
bznein
changed the title
- removed exporting updateRatesConfig as it's only used internally - changed to named ES6 export - updated typed imports
Fixed some rendering bug that caused the UTXO view to be empty after selecting an UTXO. Steps to reproduce: 1) open coincontrol utxo view on mobile 2) scroll down 3) select an UTXO result: empty dialog expected: same utxo view with selected UTXO
Fixed sleeps were causing failures whenever startup or sync took longer than expected, transaction assertions were racing backend/account updates, and teardown could trip over processes that had already exited. Some scenarios were also influenced by state left behind by previous runs. Make the suite wait for real readiness and sync boundaries, and tighten cleanup and state isolation so the tests fail for actual behavior changes.
We want different retries to save servewallet and simulator logs in different directories, so that in case of flaky tests, we can analyze older runs.
Temporarily disable this test until we can figure out why it fails. This is the cause of the vast majority of our CI failures for Playwright.
To guide the user to focus on the device for address verification.
Keep allowing users to resize textarea elements, but only vertically as the UI does not adopt to horizontal resizing.
Updated styling of all textarea elements to have same look and feel (border-radius, focus color).
Wallet groups were previously sorted by root fingerprint. When wallets have different names, the UI hides the root fingerprint, which makes the ordering look arbitrary. Sort wallets by name before root fingerprint so users can control display order through naming.
- Sorts the accounts again, as they are first sorted by keystore name - Updates sidebar and other accounts views with updated keystore name
Long text strings in dialog and wait-dialog did not break to new lines but caused a horizontal scrollbar.
To guide the user to focus on the device to confirm the address.
Dev VM documentation
Long text multiline text should be left aligned and not centered.
Fixed account-name not visible on mobile for coins with 9+ decimals.
Similar to all-accounts account-names should be shortened with … on small screens.
Collaborator
Author
|
Sorry @thisconnect, added you as reviewer before realizing there are merge conflicts, will solve them first and ping you when ready |
…ed-II Conflicts: frontends/web/src/routes/account/info/buy-receive-cta.tsx Related commit: 21df462
Ensure that a keystore is connected when performing swap, so that we don't have to ask for connecting after.
bznein
force-pushed
the
frontend/swap-account-selection
branch
from
ab3ea61 to
0bc32cf
Compare
Collaborator
Author
|
This branch became a mess, sorry about that, will open a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before asking for reviews, here is a check list of the most common things you might need to consider: