frontend: move web config access into config context/provider by smokyisthatyou · Pull Request #3916 · BitBoxSwiss/bitbox-wallet-app

smokyisthatyou · 2026-03-04T15:50:34Z

Add ConfigContext + ConfigProvider in frontends/web and refactor React components/hooks to consume getConfig/setConfig through useConfig() instead of importing utils/config directly. Keep non-React config consumers on the shared utils/config implementation path, and update related hook dependency arrays.

Before asking for reviews, here is a check list of the most common things you might need to consider:

updating the Changelog
writing unit tests
checking if your changes affect other coins or tokens in unintended ways
testing on multiple environments (Qt, Android, ...)
having an AI review your changes

cc @thisconnect

thisconnect · 2026-03-06T09:05:47Z

nice, please make one more change/commit. Currently each component still does a get request when using getConfig.

Instead it could call getConfig once on startup and keep the "config" object in the context. getConfig could then either read out the local "config" object, or context could expose "config" object along with setConfig. I am not sure what is better.

With this all components that depend on "config" object can read from the context without doing an additional api call.

We want the source of truth still to be the backend, so in the context it should update the "config" object after setConfig and fetch from the api.

Also the api function in utils should be moved into frontends/web/src/api/config.ts

shonsirsha · 2026-03-10T06:08:38Z

concept ACK

smokyisthatyou · 2026-03-30T15:50:02Z

@thisconnect moving this from draft, rebased

smokyisthatyou · 2026-03-30T18:11:26Z

@thisconnect ptal whenever you have time 🙏

thisconnect

thank you I think we should merge this first step soon, as it reduces api calls to the config endpoint and is the base for further updates: like fully typing TConfig

thisconnect · 2026-03-31T09:58:39Z

-};
+export type { TConfig };
+
+let pendingConfig: Partial<TConfig> = {};


Thinking about what it takes to move this into the react context.

The only place getConfig is used outside of react (component, hook, context) is in i18n/config.ts which is called once on app start. Here we could just use getConfig from api.

Similarly setConfig is used by i18n/i18n.ts, which is called once on startup (maybe not necessary) and when the user actively changes the language. Here I believe we cannot use setConfig from context, but there might be some workarounds (not 100% sure).

Other than for that we could move pendingConfig + the logic in setConfig into a context in the future.

I think we should test/merge as is and in the future PR's:

try to move this pending variable and logic into context.

type config fully

both changes can be done independently

thisconnect · 2026-03-31T10:01:12Z

-    getConfig().then(({ backend }) => setUsesProxy(backend.proxy.useProxy));
-  }, []);
+  const { config } = useConfig();
+  const usesProxy = (config?.backend?.proxy as { useProxy?: boolean } | undefined)?.useProxy;


Once we have config object fully typed in a future PR, this type casting can be simplified a lot or even removed completely.

thisconnect · 2026-03-31T11:04:43Z

+    const frontend = config?.frontend;
+    if (frontend && typeof frontend === 'object') {
+      if (frontend.guideShown !== undefined) {
+        setGuideShown(Boolean(frontend.guideShown));


Once we fully type TConfig in the future these safeguards can mostly be removed.

smokyisthatyou · 2026-04-13T08:10:33Z

@jadzeidan while working on this pr i think i introduced an old behaviour of the app that was opening the guide on first run. i implemented the code thinking it was the current expected flow, but @thisconnect pointed out this was actually deprecated in v4.40.

personally i’m not a huge fan of the auto-opening guide for aesthetic reasons, though I can see the utility.
do you think we should reintroduce this or keep it as is?

jadzeidan · 2026-04-13T09:26:40Z

thanks @smokyisthatyou for finding this 😄

I agree that guide shouldn't open automatically, so let's keep the "new" behaviour.

- Introduce ConfigProvider and ConfigContext and wrap app with provider - Fetch config once when the app loads and expose config + setConfig via useConfig - Refactor config consumers to read from context instead of calling getConfig per component

Stop auto-opening the guide when no frontend config is present. This prevents the guide overlay from blocking interactions on fresh starts.

- Add TFrontendConfig with known frontend settings flags and keep index signature - Update consumers to use typed config.frontend keys and drop casts/guards

- Add TBackendConfig and related types to api/config and use them in TConfig - Introduce TConfigUpdate so setConfig can accept partial backend/frontend updates - Update utils/config and ConfigProvider/Context to use TConfigUpdate merge + pendingConfig - Drop remaining backend casts in offline-error, electrum-servers, and RatesProvider

thisconnect requested a review from shonsirsha March 10, 2026 05:44

thisconnect requested review from thisconnect and removed request for shonsirsha March 10, 2026 12:39

thisconnect requested changes Mar 10, 2026

View reviewed changes

smokyisthatyou force-pushed the config-context-provider branch from 30401e1 to ea60d60 Compare March 12, 2026 16:16

smokyisthatyou force-pushed the config-context-provider branch from ea60d60 to 4da6264 Compare March 30, 2026 14:48

smokyisthatyou marked this pull request as ready for review March 30, 2026 15:49

thisconnect requested changes Mar 30, 2026

View reviewed changes

Comment thread frontends/web/src/api/config.ts Outdated

Comment thread frontends/web/src/api/config.ts

Comment thread frontends/web/src/components/status/status.tsx Outdated

thisconnect requested changes Mar 31, 2026

View reviewed changes

smokyisthatyou force-pushed the config-context-provider branch from e991fa0 to 8fb8728 Compare March 31, 2026 13:29

thisconnect mentioned this pull request Apr 7, 2026

frontend: unify vendor iframe shell behavior #3914

Merged

smokyisthatyou force-pushed the config-context-provider branch 7 times, most recently from ed28dd9 to 925a212 Compare April 10, 2026 10:44

smokyisthatyou force-pushed the config-context-provider branch from 96ad8f0 to d730016 Compare April 13, 2026 11:29

smokyisthatyou and others added 4 commits April 13, 2026 15:10

frontend: keep guide hidden by default on first run

74ceff1

Stop auto-opening the guide when no frontend config is present. This prevents the guide overlay from blocking interactions on fresh starts.

frontend: type frontend config keys in TConfig

d9b488e

- Add TFrontendConfig with known frontend settings flags and keep index signature - Update consumers to use typed config.frontend keys and drop casts/guards

smokyisthatyou force-pushed the config-context-provider branch from d730016 to cacf20f Compare April 13, 2026 13:20

Conversation

smokyisthatyou commented Mar 4, 2026

Uh oh!

thisconnect commented Mar 6, 2026

Uh oh!

shonsirsha commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smokyisthatyou commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smokyisthatyou commented Mar 30, 2026

Uh oh!

thisconnect left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thisconnect Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

thisconnect Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

thisconnect Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thisconnect Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

smokyisthatyou commented Apr 13, 2026

Uh oh!

jadzeidan commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thisconnect left a comment •

edited

Loading

thisconnect Mar 31, 2026 •

edited

Loading