Shared library support for C API#451
Open
santiberna wants to merge 9 commits into
Open
Conversation
santiberna
force-pushed
the
basisu-shared-c-api
branch
from
555a4b3 to
c137fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for compiling basis universal as a shared object (.dll or .so). Only the C API (basisu_wasm_api.h and basis_wasm_transcoder_api.h) has been exposed.
Main changes:
BASISU_SHAREDhas been added to control compiling as a shared library.BASISU_APImacro for exporting symbols, in newbasisu_config.hfile.Currently, compiling the tool or example executables with this feature enabled fails since they require access to the full basisu API which is not exported (maybe we can disable compiling those targets or add a cmake warning when attempting this). It works perfectly for the C API example.