Skip to content

Add CMake install rules#409

Open
Pandapip1 wants to merge 1 commit intoBinomialLLC:masterfrom
Pandapip1:cmake-install-targets
Open

Add CMake install rules#409
Pandapip1 wants to merge 1 commit intoBinomialLLC:masterfrom
Pandapip1:cmake-install-targets

Conversation

@Pandapip1
Copy link

I don't actually think this conflicts with #408. I've done some testing but definitely not enough for me to consider undrafting this just yet.

@richgel999
Copy link
Contributor

This is awesome - and looks quite safe to merge. I'll do some testing and get it into our January 2026 release - maybe sooner.

@Pandapip1
Copy link
Author

Pandapip1 commented Nov 7, 2025

It looks like there's at least one issue in that the header files aren't found correctly (e.g. StereoKit needed a patch to go from #include <basisu_transcoder.h> to #include <basisu/basisu_transcoder.h> to build). This is probably wrong, and I'm still troubleshooting it but I'm working on getting everything for stardust-xr-server 0.45.1 building and working and then fixing issues like this. I think it's probably as easy as modifying like 321 but with the amount of changes I'm making I have to prioritize stuff.

@Pandapip1 Pandapip1 force-pushed the cmake-install-targets branch from e2f294d to f399d5c Compare February 4, 2026 23:16
@Pandapip1
Copy link
Author

Fixed merge conflict and the headers are now installed to the correct location

@Pandapip1 Pandapip1 marked this pull request as ready for review February 4, 2026 23:16
@Pandapip1
Copy link
Author

Looks like master's formatting is failing, hence the failed check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants