pct-time-canada #149
Open
pct-time-canada #149
+37
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated SDCGCBG to include master file surveys and appropriate categorization
updated SDCGRES to have master file surveys; updated SDCGRES_A to have master files surveys; for 2001 to have be in SDCGRES_A (continuous) took the midpoint of SDCGRES categories to convert this from categorical to continuous such that 2001 now has a continuous value to be included in SDCGRES_A
updated pct_time_der function to use continuous values of age and SDCGRES_A
renamed master survey cycle pct_time_der variable
removed public survey cycles from pct_time_der_A for 2001 master survey harmonization to continuous value
created continuous SDCGRES variable for master survey cycles to use to calculate pct-time-canada
new variable for master survey cycles deriving pct-time-canada using continuous SDCGRES
yulric
changed the base branch from
feature/v3.0.0-validation-infrastructure
to
diet-score
yulric
force-pushed
the
pct-time-canada
branch
from
56f5f9e to
bcb0aff
Compare
yulric
requested changes
Nov 10, 2025
Contributor
yulric
left a comment
yulric
left a comment
There was a problem hiding this comment.
The database names in the variables and variable details sheet are not consistent. The variables sheet uses _m whereas the variable details sheet uses _i. Can you fix that?
Author
|
@yulric suffixes have been fixed |
yulric
requested changes
Nov 20, 2025
Contributor
yulric
left a comment
yulric
left a comment
There was a problem hiding this comment.
I'm still seeing _i suffixes in the SDCGRES variable in the variable details sheet
Author
|
@yulric the suffixes for SDCGRES have been changed to _m |
yulric
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
included master survey cycles 2001-2018 to SDCGCB (pct_time_der dependent) in variable_details
created SDCGRES_A variable for master survey cycles 2001-2018 which is continuous value of SDCGRES. Note, for 2001 only categorical SDCGRES is available; therefore, SDCGRES_A takes mid-point of year range for each category (i.e. category 1 is 1-9 years so continuous value of 4.5yrs is assigned for SDCGRES_A). For 2003-2018, the real value of SDCGRES is continuous in master survey cycles so values are copied over for SDCGRES_A
created pct_time_der_A for master survey cycles 2001-2018 which takes DHHGAGE_cont, SDCGCB and SDCGRES_A (pct_time_der is derived using all continuous values and not converted categorical variables)
in variables.csv pct_time_der_A, SDCGCB, and SDCGRES_A are updated/included for master survey cycles 2001-2018