diet score #148
Open
diet score #148
+420
−420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added in ICES surveys to diet score derived variable
updated function diet_score_cat3 to include master survey cycles
added in master survey cycles for required diet score variables to derive diet score
included master survey cycles for diet score and diet-score dependent variables
yulric
changed the base branch from
feature/v3.0.0-validation-infrastructure
to
adl-additions
yulric
requested changes
Nov 10, 2025
Contributor
yulric
left a comment
yulric
left a comment
There was a problem hiding this comment.
The database names are not consistent between the variables and variable details sheet. The variable details sheet uses the _i suffix whereas the variables sheet uses the _m suffix. Can you fix that?
yulric
requested changes
Nov 20, 2025
Contributor
yulric
left a comment
yulric
left a comment
There was a problem hiding this comment.
I'm still seeing the extra zeros in some lines. I've replied to the comments that have them.
removed extra zero in cchs2013_2014_m cycle name for FVCDCAR, FVCDFRU, FVCDJUI, FVCDPOT, FVCDSAL, FVCDTOT, FVCDVEG
yulric
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FVCDFRU, FVCDSAL, FVCDPOT, FVCDCAR, FVCDVEG, FVCDJUI (diet_score dependent variables) updated to include master survey cycles from 2001-2018
diet_score updated to include master survey cycles from 2001-2018
diet_score_cat3 updated to include master survey cycles from 2001-2018
master survey cycles added to FVCDFRU, FVCDSAL, FVCDPOT, FVCDCAR, FVCDVEG, FVCDJUI, diet_score and diet_score_cat3 in variables.csv