Skip to content

Conversation

@caitlink12
Copy link

@caitlink12 caitlink12 commented Oct 8, 2025

added HTWDBMI_der (derived BMI) calculated with HTWDHTM (continuous height) HWTDWTK (continuous weight) for master files 2001-2018 into variable_details
added HWTDCOR_der (corrected BMI) calculated using HWTDHTM (continuous height) and HWTDWTK (continuous weight) for master files 2001-2018 into variable_details
added HTWDBMI_der and HWTDCOR_der along with necessary information in variables.csv

included 2001 into derived adjusted BMI (grouped)
created adjusted derived BMI variable with true height and weight values for ICES surveys
2001_m has non-grouped height and weight variables to use for HWTDCOR so do not need to include it in HWTGCOR
added in HWTDBMI_der, HWTDBMI_der_cat4, and HWTDCOR_der for master files to use continuous height and weight values
@yulric yulric changed the base branch from feature/v3.0.0-validation-infrastructure to 5yr-age-categories October 15, 2025 18:50
Copy link
Contributor

@yulric yulric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caitlink12 I'm not sure what happened but it looks like the changes for the new BMI variables in the variables details sheet are not there (?). Do you mind re-adding them.

adjusting to track changes properly
updated HWTDBMI, HWTDBMI_der, HWTDCOR_der variables which use continuous height and weight measures
@caitlink12
Copy link
Author

@yulric the variables were still in the sheet but the changes must not have been tracked after I had to make additional adjustments to another variables after the initial push. I've re-added them in now so they should appear as a tracked change now.

Copy link
Contributor

@yulric yulric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't see the changes in the variable details sheet on Github but that's ok, I looked at the rows within the variable details sheet. The only issue I see is that the database suffixes are inconsistent between the two sheets.

corrected _i suffixes to _m for HWTDBMI, HWTDBMI_der, HWTDCOR_der, HWTDHTM, HWTDWTK
@caitlink12
Copy link
Author

@yulric I've adjusted the suffixes to _m for HWTDBMI, HWTDBMI_der, HWTDCOR_der, HWTDHTM and HWTDWTK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants