-
Notifications
You must be signed in to change notification settings - Fork 4
Roll back to Java 17 #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll back to Java 17 #463
Conversation
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR rolls back the project from Java 25 to Java 17 to support deployment on Elastic Beanstalk, which is configured for Java 17. The changes ensure compatibility while maintaining all existing functionality.
Key Changes:
- Updated Java version from 25 to 17 across all configuration files
- Refactored switch pattern matching to if-else statements for Java 17 compatibility
- Updated documentation to reflect Java 17 requirement
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated java.version property from 25 to 17 |
| xapi-client/src/main/java/dev/learning/xapi/client/StatementHttpMessageWriter.java | Refactored switch pattern matching to Java 17 compatible if-else with instanceof checks |
| .github/workflows/maven_push.yml | Updated GitHub Actions to use JDK 17 |
| .github/workflows/maven_pull_request.yml | Updated GitHub Actions to use JDK 17 |
| .github/workflows/manual-release.yml | Updated GitHub Actions to use JDK 17 |
| .github/workflows/copilot-setup-steps.yml | Updated GitHub Actions to use JDK 17 |
| .github/workflows/codeql.yml | Updated CodeQL workflow to use JDK 17 |
| .devcontainer/devcontainer.json | Updated devcontainer image and runtime configuration to Java 17 |
| README.md | Updated Java version requirement documentation from 25 to 17 |
| CONTRIBUTING.md | Updated prerequisites and installation instructions to reference Java 17 |



Description
Rolls back project from Java 25 to Java 17 for Elastic Beanstalk deployment compatibility.
Changes
Build Configuration
java.versionproperty to 17 in root POMCode Compatibility
StatementHttpMessageWriter.java:Documentation
Checklist:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
checkstyle.org/opt/hostedtoolcache/CodeQL/2.23.7/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.23.7/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.23.7/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/xapi-java/.codeql-scratch/dbs/java/working/files-to-index11448977796147658271.list --sourceArchiveDir=/home/REDACTED/work/xapi-java/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/xapi-java/.codeql-scratch/dbs/java/trap/java(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.