Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

Description

Addresses review feedback from #427 regarding race condition detection and error messaging in the release workflow.

Changes:

  • Early race condition validation: Added pre-build step that checks for conflicts before the long Maven build:

    • Detects if tag was re-created on remote after deletion (via git ls-remote)
    • Detects if branch has new commits since workflow started
    • Fails fast with actionable error message
  • Improved error messaging: Updated push step failures to explain:

    • Root cause (likely race condition from POM changes merged during build)
    • Resolution path (delete draft release, create new one via GitHub UI)
    • Whether artifacts were deployed to Maven Central
  • Tag existence handling (already in f6d0210): Step now exits with error (exit 1) when tag exists pointing to wrong commit, rather than silently succeeding

Resolves feedback from:

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits November 25, 2025 16:25
… workflow

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copilot AI changed the title [WIP] Update release process for error handling and race conditions Address feedback on release process improvements for error handling and race conditions Nov 25, 2025
Copilot AI requested a review from thomasturrell November 25, 2025 16:29
@thomasturrell thomasturrell marked this pull request as ready for review November 25, 2025 21:58
@thomasturrell thomasturrell merged commit 32df83b into thomasturrell-patch-3 Nov 25, 2025
@thomasturrell thomasturrell deleted the copilot/sub-pr-427-another-one branch November 25, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants