Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

Description

Addresses feedback from #427: when a tag already exists pointing to a different commit than the target branch head, the workflow should fail with exit 1 rather than silently succeed with exit 0.

The previous behavior caused the job to exit successfully and skip all subsequent steps (Maven release, tag push, GitHub release publish), leaving the release in a permanent draft state.

Changes:

  • Changed exit 0 to exit 1 to indicate error state
  • Updated ::warning:: to ::error:: for annotation consistency

Resolves feedback from #427 (comment)

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…here

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on release process error indication Fix release workflow to exit 1 on conflicting tag state Nov 25, 2025
Copilot AI requested a review from thomasturrell November 25, 2025 15:44
@thomasturrell thomasturrell marked this pull request as ready for review November 25, 2025 16:04
@thomasturrell thomasturrell merged commit f6d0210 into thomasturrell-patch-3 Nov 25, 2025
@thomasturrell thomasturrell deleted the copilot/sub-pr-427 branch November 25, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants