Skip to content

Conversation

@thomasturrell
Copy link
Contributor

@thomasturrell thomasturrell commented Nov 24, 2025

Description

Resolves # (issue)

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the codebase to use Java 21+ language features, specifically replacing if/else chains with switch expressions and using unnamed variables (underscore) for unused exception parameters. It also updates several build dependencies to newer versions.

Key Changes:

  • Replaced if/else chain with switch expression using pattern matching and guarded patterns in StatementHttpMessageWriter.getParts()
  • Updated unused exception variables to use underscore (_) in catch blocks across multiple files
  • Updated build tool dependencies: maven-checkstyle-plugin (3.5.0 → 3.6.0), checkstyle (10.6.0 → 12.1.2), and jjwt (0.12.6 → 0.13.0)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
xapi-client/src/main/java/dev/learning/xapi/client/StatementHttpMessageWriter.java Refactored if/else chain to switch expression with pattern matching for handling Statement and List objects
xapi-model/src/main/java/dev/learning/xapi/jackson/StrictLocaleDeserializer.java Updated catch block to use unnamed variable for unused MissingResourceException
xapi-client/src/test/java/dev/learning/xapi/client/configuration/XapiClientAutoConfigurationUsernamePasswordTest.java Updated catch block to use unnamed variable for unused IOException
xapi-client/src/test/java/dev/learning/xapi/client/configuration/XapiClientAutoConfigurationAuthorizationTest.java Updated catch block to use unnamed variable for unused IOException
pom.xml Updated maven-checkstyle-plugin, checkstyle, and jjwt versions; added explicit checkstyle dependency configuration

thomasturrell and others added 3 commits November 24, 2025 19:05
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud
Copy link

@thomasturrell thomasturrell merged commit f2ac53a into main Nov 24, 2025
4 checks passed
@thomasturrell thomasturrell deleted the 419-chore-address-outstanding-sonarcloud-issues-excluding-monsterempty-class-rules branch November 24, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore]: Address outstanding SonarCloud issues (excluding monster/empty class rules)

2 participants