Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 21, 2025

Description

Addresses all review comments from PR #404. The build was failing due to missing CRUD operations in StatementRepository, and several documentation and code quality issues were identified.

Resolves #404 (review feedback)

Changes

Repository Interface

  • Extended StatementRepository with both PagingAndSortingRepository and CrudRepository to restore findById(), save(), and saveAll() methods

StatementEntity

  • Made stored column non-nullable to prevent ordering inconsistencies
  • Added JavaDoc for constructor parameter and getter/setter methods

StatementService

  • Removed redundant sort specification from PageRequest.of() (already defined in repository method names)
  • Moved Instant.now() outside batch processing loop to ensure consistent timestamps within a batch
  • Simplified token validation and removed redundant exception handling

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits November 21, 2025 23:42
…prove validation

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 21, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/xapi-java/.codeql-scratch/dbs/java/working/files-to-index4171088314856793163.list --sourceArchiveDir=/home/REDACTED/work/xapi-java/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/xapi-java/.codeql-scratch/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add stored timestamp column for statement retrieval Address PR review feedback: fix repository interface, documentation, and validation Nov 21, 2025
Copilot AI requested a review from thomasturrell November 21, 2025 23:49
@thomasturrell thomasturrell marked this pull request as ready for review November 22, 2025 08:12
@thomasturrell thomasturrell merged commit 344cc7e into codex/implement-get-statements-since-date Nov 22, 2025
@thomasturrell thomasturrell deleted the copilot/sub-pr-404 branch November 22, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants