-
Notifications
You must be signed in to change notification settings - Fork 4
Remove release plugin arguments from pom.xml and update workflows #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
|
@copilot did you see my new comment |
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
|
@copilot do i need the --file pom.xml parameter and value |
No, However, it's currently used consistently in other workflows ( For consistency with |
|



Description
The maven-release-plugin fails when
-plarguments are passed via<arguments>configuration in pom.xml:Resolves https://github.com/BerryCloud/xapi-java/actions/runs/19414252617
Changes
pom.xml
<arguments>configuration from maven-release-pluginWorkflows
-pland-amflags directly in all Maven commands with consistent syntax across both workflowsmaven-publish.yml: Place-pland-amflags directly before therelease:prepare release:performgoalsrelease.yml: Place-pland-amflags directly before bothrelease:prepareandrelease:performgoalsExample from
maven-publish.yml:mvn -B -pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am -batch-mode release:prepare release:perform --file pom.xmlExample from
release.yml(release:prepare):Example from
release.yml(release:perform):Both workflow files now use the same consistent syntax with
-pland-amflags placed directly in the Maven command (not wrapped in-Darguments), ensuring only production modules (xapi-model, xapi-client, xapi-model-spring-boot-starter) are released while excluding all sample modules.Checklist:
Public methods are documented
Public methods are tested
New and existing tests pass when run locally
There are no new warnings or errors
Fixes [Chore]: Remove release plugin arguments from pom.xml and update workflows #354
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.