-
Notifications
You must be signed in to change notification settings - Fork 4
Prevent sample modules from being published to Maven Central #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ven Central Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
|
@copilot when i look at the effective pom i dont see nexus-staging-maven-plugin in the plugins. It is in the plugin management though. |
You're right - the plugin is in pluginManagement and activated via the release profile with extensions=true. However, the configuration IS working correctly. When I check the effective POM, my <execution>
<id>injected-nexus-deploy</id>
<phase>deploy</phase>
<configuration>
<skipNexusStagingDeployMojo>true</skipNexusStagingDeployMojo>
</configuration>
</execution>The nexus-staging-maven-plugin with extensions=true automatically replaces maven-deploy-plugin behavior, and our configuration properly skips this for samples. The configuration is needed and functional. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot did you perform a dry run |
Yes, I performed a dry run with Main modules deployed (9 artifacts):
Sample modules deployed: 0 artifacts Build output shows:
All 33+ sample modules are successfully excluded from deployment while main modules proceed normally. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|



Description
Sample modules are demonstration code not intended for distribution. During Maven releases, they were inheriting publishing plugins from the parent POM.
Resolves #324
Changes
Modified
samples/pom.xmlto disable all publishing-related plugins:The existing
maven-deploy-pluginskip configuration remains in place.Impact
Checklist:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
repository.sonatype.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java -classpath /home/REDACTED/work/xapi-java/xapi-java/.mvn/wrapper/maven-wrapper.jar -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/xapi-java/xapi-java org.apache.maven.wrapper.MavenWrapperMain clean install -DskipTests(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.