Skip to content

Conversation

@subash-nagarkoti123
Copy link
Collaborator

@subash-nagarkoti123 subash-nagarkoti123 commented Dec 5, 2025

Overview

This PR resolves multiple errors raised by the pre-commit hooks, including pylint, flake8, docstring, stylelint, and codespell violations. All required fixes were applied to ensure the repository passes pre-commit checks successfully.

Fixes Included

✔ Docstring Updates

  • Added missing docstrings for public modules, classes, functions, and methods.
  • Ensured compliance with flake8-docstrings.
  • Follwed existing diasbles: D202, D205, D400, D401, F401, F541.

✔ Pylint Fixes

  • Corrected pylint-reported issues such as unused imports, incorrect arguments, bad naming, and logic warnings.
  • Followed existing disables: C0114, C0115, C0116.

✔ Flake8 Fixes

  • Addressed formatting issues (line length, whitespace, formatting).
  • Ensured compatibility with Black and isort output.
  • Applied suppressions only when required.

✔ Formatting & Linting

  • Formatted code using Black and isort.
  • Fixed end-of-file, trailing whitespace, JSON formatting.
  • Cleaned up Go files via go fmt and go mod tidy.

✔ Codespell & Stylelint

Fixed spelling issues and updated .codespell-ignore-words where appropriate.
Resolved CSS/SCSS lint errors based on .stylelintrc.json.

Verification

All hooks now pass successfully after running:

  • pre-commit clean && pre-commit install
  • pre-commit run --all-files

Result

This PR improves code quality, consistency, and ensures smooth pre-commit validation for future commits.

Closes #19

@subash-nagarkoti123 subash-nagarkoti123 self-assigned this Dec 5, 2025
@subash-nagarkoti123 subash-nagarkoti123 added the bug Something isn't working label Dec 5, 2025
@subash-nagarkoti123 subash-nagarkoti123 changed the title Fix Pre-Commit Hook Issues (Pylint, Flake8, Docstrings, Stylelint, Codespell) fix(pre-commit): resolve pylint, flake8, docstring, stylelint, and codespell issues Dec 5, 2025
@subash-nagarkoti123 subash-nagarkoti123 changed the title fix(pre-commit): resolve pylint, flake8, docstring, stylelint, and codespell issues fix(precommit): resolve pylint, flake8, docstring, stylelint, and codespell issues Dec 5, 2025
@mergeable mergeable bot added the validated label Dec 5, 2025
@umesh-khatiwada umesh-khatiwada merged commit 143215e into main Dec 5, 2025
4 checks passed
@umesh-khatiwada umesh-khatiwada deleted the fix/subash/pre-commit branch December 5, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working validated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Pre-Commit Hook Errors Across ClusterManager

5 participants