Merged
Conversation
anarchivist
force-pushed
the
AP-496
branch
2 times, most recently
from
8ffcba0 to
dfd6302
Compare
also adds license file and updates link to B-Drive docs
danschmidt5189
approved these changes
Jan 8, 2026
Member
danschmidt5189
left a comment
danschmidt5189
left a comment
There was a problem hiding this comment.
Minor suggestion / rationale around declaring environment variables, but besides that looks good!
docker-compose.ci.yml
Outdated
| image: ${DOCKER_APP_IMAGE} | ||
| environment: !override | ||
| LDAP_HOST: ldap.fake.edu | ||
| LDAP_PASS: FAKEPW |
Member
There was a problem hiding this comment.
It's not a hard requirement, but my suggestion is to standardize on the list / key=val syntax wherever possible because:
- The merge logic is effectively identical between the dict/list formats, so you don't lose anything.
- You gain the ability to copy/paste directly into Docker CLI commands.
- Because key=val forces YAML to parse everything as a string (which is what these always are), you can avoid some edge cases around, for example, a boolean
trueversus string"true".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also adds license file and updates link to B-Drive docs