Skip to content

Add tests for multiple assignments and unpacking#402

Merged
dfremont merged 3 commits intoBerkeleyLearnVerify:mainfrom
lola831:tests/assignments-unpacking
Apr 2, 2026
Merged

Add tests for multiple assignments and unpacking#402
dfremont merged 3 commits intoBerkeleyLearnVerify:mainfrom
lola831:tests/assignments-unpacking

Conversation

@lola831
Copy link
Copy Markdown
Collaborator

@lola831 lola831 commented Oct 21, 2025

Description

Adds tests for multiple assignments and unpacking.

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@lola831 lola831 requested a review from dfremont October 21, 2025 18:16
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (40d8d1d) to head (c19ff46).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   89.85%   89.74%   -0.11%     
==========================================
  Files          54       48       -6     
  Lines       13549    13194     -355     
==========================================
- Hits        12174    11841     -333     
+ Misses       1375     1353      -22     

see 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The essence of the tests looks good, but let's simplify them by not using dynamic simulations (just top-level code rather than behaviors). You can use sampleParamPFrom to get simple values out if needed.

@lola831
Copy link
Copy Markdown
Collaborator Author

lola831 commented Nov 17, 2025

@dfremont I’ve simplified the tests to use top-level code rather than behaviors.

@lola831 lola831 requested a review from dfremont November 17, 2025 20:57
Comment thread tests/syntax/test_assignments.py Outdated
Comment thread tests/syntax/test_assignments.py Outdated
Copy link
Copy Markdown
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor comments above.

@lola831
Copy link
Copy Markdown
Collaborator Author

lola831 commented Mar 31, 2026

@dfremont Thanks for the review. I’ve addressed the two comments above and pushed the updates.

@lola831 lola831 requested a review from dfremont March 31, 2026 22:02
@dfremont dfremont merged commit 6cfdbc7 into BerkeleyLearnVerify:main Apr 2, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants